quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.73k stars 285 forks source link

[Bug]: Files dragged to the shelf don't stay there across sessions. #2873

Closed g1oria closed 2 months ago

g1oria commented 2 years ago

Before submitting your bug report, please confirm you have completed the following steps

Bug description

Alias folders/files added to the shelf via the interface stay just fine in the shelf across sessions, but aliases added via drag & drop do not. See video for demo.

https://user-images.githubusercontent.com/17694864/167720897-c715d093-2b70-4ef1-8a22-0bcc23bf10ad.mp4

Steps to reproduce

  1. Drag & drop an alias from Finder to shelf.
  2. Relaunch QS.
  3. Item isn't there.

Expected behavior

Items added to the shelf via either method should stay across sessions.

MacOS Version

macOS 10.15

Quicksilver Version

2.1.0

Relevant Plugins

Shelf

Crash Logs or Spindump

No response

Screenshots

No response

Additional info

No response

pjrobertson commented 2 years ago

Thanks for the video, Gloria. That's helped in isolating the issue. I've renamed and edited your Bug Report for clarity

g1oria commented 2 years ago

You're welcome & thanks! 😁Message ID: @.***>

pjrobertson commented 2 years ago

Developer notes:

So this issue ultimately has to do with getting items off the clipboard in QSObject_Pasteboard.m, specifically objectForPasteboardType. Really, we should switch away from the hacks in there, to the newer NSPasteboardWriting and NSPasteboardReading protocols.

stale[bot] commented 3 months ago

This issue hasn't been updated in over 2 years. It has been marked as 'stale' and will be closed in 30 days. Please check whether this is still an issue with the latest version of Quicksilver. If so, update or comment on this issue to keep it open.