search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.72k stars 283 forks source link

[Bug]: Version 2.2.0 is unpredictable #2880

Closed skurfer closed 2 years ago

skurfer commented 2 years ago

Before submitting your bug report, please confirm you have completed the following steps

Bug description

As far as I can tell, pressing ↩ to execute a command causes one or more panes to change to something else just before execution.

I’ve seen actions change to things that shouldn’t be allowed in the 2nd pane and I’ve seen the first pane change to and launch a different app.

The scary thing is, you don’t know what’s going to happen because everything is fine right up until you hit ↩.

Steps to reproduce

Alternate actions

  1. Select a Remote Host

  2. Hold ⌘ to change the action to SSH as Root

  3. Press ↩

  4. The action switches from SSH as Root to DuckDuckGo which is my default web search.

  5. Thankfully, nothing happens since that’s not an action.

  6. Select a file (I had an smb.conf laying around that I used)

  7. Hold ⌘ to change the action to Reveal

  8. Press ↩

  9. Earlier, the action would change to Use as Remote Host and run, but now it seems to change to DuckDuckGo

Launching Apps

I can’t reproduce this with all apps, but Little Snitch does it pretty regularly. I just launched Little Snitch 3 times and here’s what launched:

Expected behavior

Pressing ↩ should not change the selection in any of the panes.

I’m looking into this, but a lot has changed recently so if this sets off any lightbulbs, let me know.

MacOS Version

macOS 12

Quicksilver Version

2.2.0

Relevant Plugins

No response

Crash Logs or Spindump

No response

Screenshots

No response

Additional info

No response

n8henrie commented 2 years ago

Hmmm, yeah some funky stuff. I've been out of town and hadn't updated until I saw this.

Picked a URL -> open url and instead I saw this:

Screen Shot 2022-05-23 at 15 58 04

Just did google.com -> open url a few times and it copied to clipboard instead. google.com -> type text worked. google.com -> open url again and it typed the text a second time.

You can briefly see it change as you hit enter.

We should probably keep the tag but take down the release (at least for the moment). I don't think this ever got pushed to qsapp.com. EDIT: Marked as pre-release for the moment.

skurfer commented 2 years ago

If it’s pre-release, maybe it’s OK to leave it for now? I haven’t looked lately at how many people are getting them. I’m getting Developer Previews, of course. I’ll go back to 2.1.0 while we investigate.

Side note: The site is showing 2.2.0 as the latest version, but it correctly gives you 2.1.0 when you download.

kzykx commented 2 years ago

alternative action ( triggered by Command + Enter) does not work properly.

kzykx commented 2 years ago

https://user-images.githubusercontent.com/102411489/170011408-0398b0bd-b81f-4b3d-9cc2-5cb8a131d497.mov

fraserw commented 2 years ago

Can confirm. Opening applications by pressing enter usually triggers a Chrome action, opening a new window and trying to "load the app". Mouse click on the app in the dropdown list triggers the correct action.

pjrobertson commented 2 years ago

I've just noticed this. I've dropped 2.2.0 back down to pre-release and will look into it today. My guess is it's to do with the search string clearing from #2642

pjrobertson commented 2 years ago

I found the issue, and fixed it in 39c50f2b22c45686e5930de8791d689f7f205d1d

pjrobertson commented 2 years ago

Please update to version 2.2.1, thanks!