search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.75k stars 286 forks source link

keep debug version #2938

Closed n8henrie closed 1 year ago

n8henrie commented 1 year ago
n8henrie commented 1 year ago

@skurfer we're getting:

Error: HTTP status code: 403. A required agreement is missing or has expired. This request requires an in-effect agreement that has not been signed or has expired. Ensure your team has signed the necessary legal agreements and that they are not expired.

Are we okay to keep using your certificate? If so, do you get any notification when you log into your Apple Dev account?

skurfer commented 1 year ago

Sorry, just now getting to this. The developer account had expired. I just renewed it. I’ll e-mail you my cell so you can get to me faster for stuff like this.

n8henrie commented 1 year ago

I'll probably cut a fake release to make sure this works and if so merge.

I'm really hoping a debug version available for download helps sort out these intermittent crashing issues.

pjrobertson commented 1 year ago

The code here looks good to me. However it appears the developer cert still needs updating.

@n8henrie did you manage to get the login details from @skurfer for the dev account?

If yes: Rob - you need paying for this year. If no: We can set up a new developer account to get builds signed (regardless, Rob should still be reimbursed).

n8henrie commented 1 year ago

@pjrobertson @skurfer I did not get account details, Rob renewed and I suspected it would just start working again, but the signing is giving an error:

A required agreement is missing or has expired. This request requires an in-effect agreement that has not been signed or has expired. Ensure your team has signed the necessary legal agreements and that they are not expired.

Rob, if you log into the account, does it present you with some kind of EULA?

EDIT: Looks like same error as https://github.com/quicksilver/Quicksilver/issues/2895

skurfer commented 1 year ago

I accepted the agreement and qssign is working locally for me.

n8henrie commented 1 year ago

Signing is not working, thanks @skurfer

Looks like I need to fix the debug artifact: Error: Unable to find an artifact with the name: Quicksilver-debug.zip

n8henrie commented 1 year ago

Hope nobody minds the quickfix pushes to main for this, CI stuff is kind of painful to work with via branches (since the branch itself often determines the CI process).