search

quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.72k stars 283 forks source link

Debug uploading the debug artifact #2955

Closed n8henrie closed 10 months ago

n8henrie commented 10 months ago

This branch was to help debug CI for https://github.com/quicksilver/Quicksilver/pull/2938#issuecomment-1694694593

n8henrie commented 10 months ago

I think this is ready for merge. It uploads a debug executable along with the release artifacts, which should hopefully empower end users to help us debug issues.

n8henrie commented 10 months ago

I've also updated the CI dependencies in this PR, which silences several annoying warnings.

pjrobertson commented 10 months ago

I see Quicksilver-debug here :) https://github.com/quicksilver/Quicksilver/actions/runs/6007687787

Can it be given an extension in the name. Is it a .zip or .dmg?

pjrobertson commented 10 months ago

@n8henrie - waiting on this change (Adding an extension) then I'll push a new release out :)

n8henrie commented 10 months ago

@pjrobertson -- I actually removed the .zip extension due to: https://github.com/actions/upload-artifact#zipped-artifact-downloads:

There is currently no way to download artifacts after a workflow run finishes in a format other than a zip or to download artifact contents individually. One of the consequences of this limitation is that if a zip is uploaded during a workflow run and then downloaded from the UI, there will be a double zip created.

So I had originally made it so that one saw foo.zip in the web interface, but once downloaded it showed as foo.zip.zip which I thought seemed uglier than having foo in the web interace and foo.zip once downloaded. I still think the latter is less ugly, but if you think it's more important to show the .zip in the web interface I'm happy to revert that.

pjrobertson commented 10 months ago

Makes sense. I see that when I download it it is correctly named Quicksilver-debug.zip, so I think this change is fine.

Merging :)