Closed torley-gallium closed 4 months ago
Same here.
Defaults to Large Type
always:
Pressing
Tab
and then O
will do the trick, but involves 2 extra clicks, every single time:
@pjrobertson i wonder if this (and the other issue with shortcuts) could be related to the changes I made to get tests passing, in which I made sure that application paths were also recognized as valid objects for text actions.
If so, perhaps default action sorting can use guessPrimaryType
?
Will need to look into this. On mobile now.
@corporate-gadfly THANK YOU very much for the screenshots and substantiating that it's not just me.
I updated QuickSilver to 2.4.1 on a second Mac and it also repros.
@n8henrie I appreciate you looking into this!
For anyone seeing this, the workaround is to open the Quicksilver settings, go to General -> Actions, search for "large type" and uncheck it.
The "large type" fix worked for me as well. Sounds like another update is needed.
For anyone seeing this, the workaround is to open the Quicksilver settings, go to General -> Actions, search for "large type" and uncheck it.
This just disables the Large Type
action, which can be pretty useful (I use it all the time to make it easier to show text to bystanders) -- I recommend we find a better solution.
Unfortunately, I'm unable to reproduce the issue. Can you please try these steps?
Quicksilver-debug.zip
from https://github.com/quicksilver/Quicksilver/releases/tag/v2.4.1mv ~/Library/Application\ Support/Quicksilver{,.bak}
~/Library/Application Support/
and manually rename Quicksilver
to something like Quicksilver.bak
~/Library/Caches/Quicksilver
Quicksilver-debug.zip
Quicksilver.app
and click Open
(double clicking won't work)Preview
Open
. If I type tabl it then goes to Large Type
Quicksilver-debug
and don't forget to mv ~/Library/Application\ Support/Quicksilver{.bak,}
(or otherwise reverse the renaming from above)I can reproduce the problem in the debug build.
Of course -- the debug build is essentially unchanged from the version used to open the issue. The question is whether the issue persists after quitting QS, deleting ~/Library/Caches/Quicksilver
, and "hiding" ~/Library/Application Support/Quicksilver
Thanks for getting back to me quickly -- can you confirm that you also took the other steps?
@n8henrie : I hear you. I use Large Type
all the time, but the hit of not being able to open every single time was just too much. Hence the work around of disabling it.
I must admit, I'm guilty of not following your debug procedure, but, IMO, all your instructions prove is that this scenario doesn't happen with a clean install of 2.4.1
. A few of us, who have existing 2.4.0
, under certain conditions (or all?), when we ugpraded to 2.4.1
, the bug happened automatically without doing anything else.
I did delete the caches, but I didn't see the bit about hiding the application support folder. Let me try again.
OK, I don't see the issue when I hide Application Support/Quicksilver.
So it sounds like the issue possibly has to do with your local configuration or action ranking, possibly something in ~/Library/Application Support/Quicksilver/Actions.plist
?
Can you try restoring your usual app support file but temporarily renaming just that file? (Should probably delete the cache before each trial run regardless).
Renaming Actions.plist makes the issue go away. Would it help if I uploaded my Actions.plist?
Renaming Actions.plist makes the issue go away. Would it help if I uploaded my Actions.plist?
I can confirm the same.
The original file (that I backed up) and the one that automatically got created at next run are radically different. Here's the line count:
wc -l Actions-2023-09-13.plist Actions.plist
1720 Actions-2023-09-13.plist
1114 Actions.plist
I'm not sure that uploading your actions plist is necessary, thanks for the offer, I'll let you know if that changes.
I think the issue is that applications are now seen as eligible targets for string actions; for example, one can select Safari.app
and then run Large Type
and see /System/Volumes/Preboot/Cryptexes/App/System/Applications/Safari.app
in large text, just like one can enter Hello there!
or any other string and show that in large type.
The issue is that -- for whatever reason -- Large Type
has become the default action on your system.
IIRC, for Large Type
to become automatically eligible for the action, the text had to have a .
. If it didn't, then you could still make it the action by tabbing over. Do I recall correctly?
Following that train of thought, is /
the new .
?
"Large type" is rank 24 in the settings. Presumably something is overriding that ranking.
Oh I just noticed that "open/reveal" is rank 25. I had thought that the rank 1 "run/open" was the open action. If I move that above "large type" it also fixes the issue.
Naive question. What would I lose by removing the original Actions.plist
? Actions that were built up over the years by installing other software?
I think you'd lose your history (for example a specific catalog item that you always want to run a specific action for).
@corporate-gadfly
all your instructions prove is that this scenario doesn't happen with a clean install of 2.4.1. A few of us, who have existing 2.4.0, under certain conditions (or all?), when we ugpraded to 2.4.1, the bug happened automatically without doing anything else.
To be fair, I am not seeing this behavior on my pre-existing QS install (updated from 2.4.0 -> 2.4.1 through the in-app updater), nor on a clean install, so I'm trying to figure out how to reproduce the issue. I am concerned that many people are running into it, so I'm trying to sort out what changes are causing this behavior.
I've added a few new tests that seem to show the default actions are correct.
What I'm speculating may be happening here (and in https://github.com/quicksilver/Quicksilver/issues/2963) is that QS's "smarts" is now detecting that objects like applications can also be interpreted as strings, and is trying to guess the best default action based on a number of inputs, such as:
For example to show the full path to Calendar.app
in large type, one can invoke QS ⇥calendar⇥tab⇥large type`, and that is a valid thing to do, and it could even be the right default action for QS to prioritize in a weird world where a user wanted to do that frequently.
I agree that it doesn't make sense as the default, but the tests above show that it isn't the default -- something about several users' histories is prompting QS to prioritize it.
Just a wild guess, but this commit removes ".app" from applications. Maybe that affects another test down the road?
https://github.com/quicksilver/Quicksilver/commit/260eee39000984b5f93ed15c0781ab7cba98204e
Thanks for the thought! That commit sets the label, which I think was previously empty / unset for applications (and why the test was previously failing).
@corporate-gadfly -- would you be willing to share your actions.plist
? I'd like to compare with my own. I don't think there would usually be anything too private in actions.plist
, but it's a little long to be sure with a glance through, so I hesitate to ask that you post it openly in the thread (though that's certainly an option). Alternatively you could email it to me; you can find my personal email at https://n8henrie.com/contact/ .
oh sorry @n8henrie for the delay.
I'm afraid that won't be possible. I deleted the file a couple of weeks ago (sorry about that) and haven't missed it one single bit.
I believe I'm having the same issue (although Quicksilver keeps trying to "Calculate" apps for me, not "Large Text"). I haven't done any workarounds yet so I'm still experiencing the issue. Here's my Actions.plist file:
Thanks @aberkvam, I'll take a closer look soon!
@corporate-gadfly @torley-gallium Would you please try running the debug version from here and see whether or not the unwanted behavior changes?
@n8henrie Sorry for the delay, just saw this. I appreciate all your care and investigation. Is there a new debug version to try? 2.4.2 still repros the issue for me (haven't deleted anything else).
@aberkvam @torley-gallium can you please try this and report back: https://github.com/quicksilver/Quicksilver/issues/2963#issuecomment-1912822642
@n8henrie Thanks for checking in, so far so good with 2.4.2 . I don't see the enlarged text.
Before submitting your bug report, please confirm you have completed the following steps
Bug description
QuickSilver 2.4.1 is broken for me on macOS Ventura 13.5.
Every time I try to launch an app, it shows giant text.
Reverted back to 2.4.0, works fine.
Steps to reproduce
Then the directory path of the app appears in a gigantic font, but it doesn't launch.
Expected behavior
It should launch the app and not freeze with giant text.
MacOS Version
macOS 13
Quicksilver Version
2.4.1
Relevant Plugins
No plugins. Just customized some colors but using Bezel.
Crash Logs or Spindump
No response
Screenshots
No response
Additional info
No response