quicksilver / Quicksilver

Quicksilver Project Source
http://qsapp.com
Apache License 2.0
2.74k stars 286 forks source link

[Bug]: Extensions appear on applications #2970

Open skurfer opened 1 year ago

skurfer commented 1 year ago

Before submitting your bug report, please confirm you have completed the following steps

Bug description

After installing 2.4.1, a few applications in the catalog were showing up with the .app extension. At this point, they all show it.

I’m looking through the diff between 2.4.0 and 2.4.1 to see if I can figure out what happened, but if someone who worked on it has any immediate theories, feel free to chime in.

Steps to reproduce

  1. Invoke Quicksilver
  2. Search for an application

Expected behavior

the name of the application will appear without .app. I forget if this respects the Finder preference for extensions or not. All I know is I didn’t see them before and now I do.

MacOS Version

Other

Quicksilver Version

2.4.1

Relevant Plugins

No response

Crash Logs or Spindump

No response

Screenshots

Screenshot 2023-09-29 at 4 35 01 PM

Additional info

No response

n8henrie commented 1 year ago

I wouldn't be surprised if it was my commit here: https://github.com/quicksilver/Quicksilver/commit/260eee39000984b5f93ed15c0781ab7cba98204e

Might be a good place to start looking at least.

n8henrie commented 1 year ago

I've reverted that commit here -- wanted to see if that fixes it?

skurfer commented 1 year ago

That doesn’t seem to be it. I’ll revert back to 2.4.0 for a minute to make sure I’m not crazy.

Confirmed: I don’t see extensions for any apps under 2.4.0. I might have time to look at this tonight.

pjrobertson commented 12 months ago

I knew it'd be me 🙈

f8d685ebab56345b5ee034a4b11bd8631b145e7b is the first bad commit
commit f8d685ebab56345b5ee034a4b11bd8631b145e7b
Author: Patrick Robertson
Date:   Sun Aug 20 14:41:32 2023 +0800

f8d685ebab56345b5ee034a4b11bd8631b145e7b

Looking into it now