search

quickwit-oss / helm-charts

Helm charts for Quickwit
https://helm.quickwit.io
MIT License
22 stars 28 forks source link

feat: add support for dual stack clusters #84

Closed M0NsTeRRR closed 5 months ago

M0NsTeRRR commented 5 months ago

Support dual stack clusters :)

rdettai commented 5 months ago

Thanks for this contribution! Can you tell us a bit more about a use case when this is useful? Even though it's just an extra feature, I'm a bit concerned by the ever growing number of tuning nobs on the chart!

Also, this conflicts with https://github.com/quickwit-oss/helm-charts/pull/83

M0NsTeRRR commented 5 months ago

Yes, indeed. Some users, like myself, operate dual-stack clusters with both IPv4 and IPv6 deployed. Quickwit for now only supports IPv4 services in dual stack configuration, as IPv4 takes precedence over IPv6 and this cannot be altered. The introduction of the ipFamilies feature allows users to prioritize IPv6 over IPv4. ipFamilyPolicy will allow user to choose if what they want to assign. Why is this significant? Well, IPv6 and IPv4 represent distinct networks, each with its own latency and speed characteristics, which can vary depending on the internet service providers. Moreover, enabling this feature facilitates the seamless operation of existing IPv6 and IPv4 network applications together.

Additionally, it's worth noting that Quickwit pods already possess IPv4, and only IPv6 services are affected, as detailed in the Kubernetes documentation here: link.

Importantly, the current implementation does not constitute a breaking change. Rather, it allow concerned users to opt into IPv6 support if they desire.

guilload commented 5 months ago

Ok to ship this feature as long as it remains invisible to users who don't care about IPv6.

rdettai commented 5 months ago

Sorry I didn't have the time to test this PR yet, I'll do it early next week. Looking good overall!

rdettai commented 5 months ago

I tested that it works without specifying the new parameters. I don't have a cluster with IPv6 configured so I can't test dual stack, but given that the current functionalities are not impact, I'm merging this anyway.