search

quickwit-oss / helm-charts

Helm charts for Quickwit
https://helm.quickwit.io
MIT License
22 stars 28 forks source link

Fix Values comments #95

Closed rdettai closed 3 months ago

rdettai commented 3 months ago

https://github.com/quickwit-oss/helm-charts/pull/92 introduced some inconistencies in the comments. This PRs fixes them.

rdettai commented 3 months ago

Also removed bootstrap.extraVolumes, bootstrap.extraVolumeMounts and bootstrap.initContainers which are dead code.

rdettai commented 3 months ago

Side note: I find it very confusing that the settings for the bootstrap extraVolumes, extraVolumeMounts and initContainers got into a separate top level section called jobs. They belong to the bootstrap section. I don´t want to change it here because it's a breaking change, but I really think we should consider it.

idrissneumann commented 3 months ago

Side note: I find it very confusing that the settings for the bootstrap extraVolumes, extraVolumeMounts and initContainers got into a separate top level section called jobs. They belong to the bootstrap section. I don't want to change it here because it's a breaking change, but I really think we should consider it.

Completely agree. This pr is merged but we can open a new issue and PR to do it later (it'll be a breaking change to document and version the right way though).

idrissneumann commented 3 months ago

@rdettai I opened an issuer for your suggestion, this way we'll see when it'll be prioritized etc: https://github.com/quickwit-oss/helm-charts/issues/98