search

quickwit-oss / quickwit-datasource

Quickwit data source for Grafana
GNU Affero General Public License v3.0
39 stars 9 forks source link

entering the Log context interface may feel it with invalid query #121

Closed trinity-1686a closed 2 months ago

trinity-1686a commented 3 months ago

when viewing context around a line, we get the following interface: image As shown on the picture, the query is prefilled, but variables aren't substituted, resulting in an invalid query. It would be handy to perform the substitution when opening the interface

ddelemeny commented 2 months ago

Thanks! The issue looks like a duplicate of #77

The query itself is OK and variable interpolation will be handled normally (the datasource API method for interpolation is called during a query call). This should display results.

The gist of the issue is that parser used for linting currently doesn't handle Grafana's query templating language, which leads to the displayed error state. I have ongoing work to fix that, but parsing mixed languages isn't quite straightforward.

trinity-1686a commented 2 months ago

maybe it would work, though I can't check, the Run query button is actually disabled for invalid queries

ddelemeny commented 2 months ago

Oooh ! Yup, definitely overlooked this detail. Will fix !