search

quickwit-oss / quickwit

Cloud-native search engine for observability. An open-source alternative to Datadog, Elasticsearch, Loki, and Tempo.
https://quickwit.io
Other
8.14k stars 331 forks source link

`test_sync_with_ingesters` fails silently #4391

Closed guilload closed 9 months ago

guilload commented 9 months ago 
guilload@mandrill ~/W/r/quickwit (main) [101]> cargo test --manifest-path quickwit/Cargo.toml -p quickwit-control-plane --lib -- --nocapture test_sync_with_ingesters

    Finished test [unoptimized] target(s) in 0.19s
     Running unittests src/lib.rs (quickwit/target/debug/deps/quickwit_control_plane-9f99cf38234e3e09)

running 1 test
thread 'ingest::ingest_controller::tests::test_sync_with_ingesters' panicked at quickwit-proto/src/ingest/../codegen/quickwit/quickwit.ingest.ingester.rs:530:46:
MockIngesterService::retain_shards: Expectation(<anything>) called 0 time(s) which is fewer than expected 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test ingest::ingest_controller::tests::test_sync_with_ingesters ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 61 filtered out; finished in 0.00s
fulmicoton commented 9 months ago

I can reproduce. It is weird the test passes.

fulmicoton commented 9 months ago

that's kind of interesting... if we panic in a task in a tokio test, it does not fail the test.