Add missing fields to ES compatible Query API

quickwit-oss / quickwit

Cloud-native search engine for observability. An open-source alternative to Datadog, Elasticsearch, Loki, and Tempo.

https://quickwit.io

Other

7.31k stars 298 forks source link

Add missing fields to ES compatible Query API #5098

Closed kuzaxak closed 1 month ago

kuzaxak commented 1 month ago

Description

_source schema
docvalue schema
multi_match schema

I've added additional fields as serde_json::Value to prevent complex struct definitions as we won't use them anyway.

Addressing https://github.com/quickwit-oss/quickwit/issues/5097

How was this PR tested?

I've tested it locally using queries taken from OSD

Additionally I've added some tests for multi_match parser code.

fulmicoton commented 1 month ago

@kuzaxak to make things smoother I merged and will commit my comments above that. Next time, could you create a feature branch on the quickwit repo (I think you have the permissions to do that)

fulmicoton commented 1 month ago

For info: https://github.com/quickwit-oss/quickwit/pull/5111

kuzaxak commented 1 month ago

@kuzaxak to make things smoother I merged and will commit my comments above that. Next time, could you create a feature branch on the quickwit repo (I think you have the permissions to do that)

@fulmicoton Could you please elaborate on what you mean by the feature branch? Create branch and point all related PRs to it and then one more Feature PR to merge it to the main one?

fulmicoton commented 1 month ago

I mean pushing a branch on quickwit-oss/quickwit.