search

quickwit-oss / quickwit

Cloud-native search engine for observability. An open-source alternative to Datadog, Elasticsearch, Loki, and Tempo.
https://quickwit.io
Other
8.01k stars 327 forks source link

Stop flamegraph only when the target duration is elapsed. #5131

Closed fulmicoton closed 3 months ago

fulmicoton commented 3 months ago

Before this PR, fetch the flamegraph was stopping the profiling even if the duration was not elapsed yet.

After this PR, the flamegraph is only generated after the duration is elapsed (still defaulting to 30s).

github-actions[bot] commented 3 months ago

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 2163, ref commit: 05559785be0a132d89ee569b0eff27fa7fb0c084
Link

On GCS:

Average search latency is 0.953x that of the reference (lower is better).
Ref run id: 2164, ref commit: 05559785be0a132d89ee569b0eff27fa7fb0c084
Link