search

quickwit-oss / tantivy-py

Python bindings for Tantivy
MIT License
275 stars 63 forks source link

Different versions for nox and maturin build #255

Closed alex-au-922 closed 5 months ago

alex-au-922 commented 5 months ago

I have found that the python interpreter versions for maturin and nox are in different versions:

# Makefile

build:
    maturin build --interpreter python3.7 python3.8 python3.9 python3.10 python3.11
#noxfile.py

@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"])
def test(session):
    session.install("-rrequirements-dev.txt")
    session.install("-e", ".", "--no-build-isolation")
    session.run("pytest", *session.posargs)

Will this lead to unexpected behavior?

cjrh commented 5 months ago

I don't think that makefile is used anywhere. The CI doesn't, for example. I think we should just delete it.

alex-au-922 commented 4 months ago

I think the makefile is still useful for testing. It helps me build the latest tantivy (local) binary for my testing in one command, I think we should not discard it.

cjrh commented 4 months ago

For this I just run maturin develop which builds the extension and installs it into a local venv. Is there anything the makefile gives beyond this?

Could you describe your workflow in more detail?

alex-au-922 commented 4 months ago

For this I just run maturin develop which builds the extension and installs it into a local venv. Is there anything the makefile gives beyond this?

Could you describe your workflow in more detail?

Oops I just found that the nox command does its job. The Makefile should be safe to discard