quicky2000 / tartini

A trial to make Tartini (The real time music analysis tool ) to evolve. Original code is located in http://miracle.otago.ac.nz/tartini/download.html
Other
8 stars 4 forks source link

Chromatic Tuner doesn't reflect temperaments #101

Closed mself closed 4 years ago

mself commented 4 years ago

The temperament combo box only affects how the pitch lines are drawn in the Pitch Contour view. It does not affect how the Chromatic Tuner judges a note to be above or below the correct pitch.

An enhancement would be to have the Chromatic Tuner compare the detected frequency to the idea pitch for the note taking into account the selected temperament.

It would also be good if other views, such as the 2D Piano and Musical Score views took the temperament into account when determining which note the detected frequency is closest to.

I suggest moving the existing logic that calculates the ideal pitches out of the Pitch Contour view and into the music folder. There would be a function to calculate the ideal pitch for a note and to determine the closest note for a given pitch.