Restore the `widgets/base/base*` files

quicky2000 / tartini

A trial to make Tartini (The real time music analysis tool ) to evolve. Original code is located in http://miracle.otago.ac.nz/tartini/download.html

Other

8 stars 4 forks source link

Restore the `widgets/base/base*` files #115

Closed mself closed 4 years ago

mself commented 4 years ago

I previously removed these files, thinking they were obsolete. But they are useful templates for creating new widgets.

Restore the widgets/base/base* files
Fix the files to bring them up to date so that they compile
Add the files to be compiled (to catch any errors)
Remove an obsolete comment in widgets/vibrato/vibratoview.cpp that was left over from copying this files from the widgets/base/baseview.cpp template
Rename BaseView and BaseWidget to SampleView and SampleWidget

quicky2000 commented 4 years ago

Could you rebase on master to make Github realise there are no conflicts ? When I do it manually and close the pull request they look like if they were rejected with a red icon instead of purple merged one. I think this is because all your PRs are chained. I guess it will not occur if PR start from master

mself commented 4 years ago

Done. I'm still not sure the best way to make the PRs. If they all start from master, then I can't build on previous work. But if they are chained it seems like they have to be rebased one at a time when you merge the previous PRs. Open to suggestions...

quicky2000 commented 4 years ago

Done. I'm still not sure the best way to make the PRs. If they all start from master, then I can't build on previous work. But if they are chained it seems like they have to be rebased one at a time when you merge the previous PRs. Open to suggestions...

I think start from master is was it the most evident for Github integration so they are all independant from each other