Add default parameter values to closestNote() and temperedPitch() to simplify usage
Uses the current global key and temperament from GData if they are not passed explicitly
Simplify code in VibratoTunerWidget and PianoView to use new default values
Prevent automatic rounding of pitches to integer values
Update noteName(double), noteOctave(double), noteValue(double), and isBlackNote(double) to use closestNote() instead of toInt()
Mark noteName(double), noteOctave(double), noteValue(double), and isBlackNote(double) as deprecated
They are not used anywhere and it is better to explicitly call closestNote() if that is what you intend
Don't delete the functions, since then a call to noteOctave(double) would use implicit conversions to call noteOctave(int), which would truncate the pitch value
Clarified distinction between "notes" and "pitches" in music_notes
Add documentation describing the difference between "note" and "pitch"
Renamed parameters from p_pitch to p_note as appropriate (and vice versa)
Renamed noteOffsetInKey() to pitchOffsetInKey()
Added @deprecated doc tags in addition to C++14 [[deprecated]] attributes
Added docstrings for temperedPitch() and closestNote() that include description of default parameter values
closestNote()
andtemperedPitch()
to simplify usageGData
if they are not passed explicitlyVibratoTunerWidget
andPianoView
to use new default valuesnoteName(double)
,noteOctave(double)
,noteValue(double)
, andisBlackNote(double)
to useclosestNote()
instead oftoInt()
noteName(double)
,noteOctave(double)
,noteValue(double)
, andisBlackNote(double)
as deprecatedclosestNote()
if that is what you intendnoteOctave(double)
would use implicit conversions to callnoteOctave(int)
, which would truncate the pitch valuemusic_notes
p_pitch
top_note
as appropriate (and vice versa)noteOffsetInKey()
topitchOffsetInKey()
@deprecated
doc tags in addition to C++14[[deprecated]]
attributestemperedPitch()
andclosestNote()
that include description of default parameter values