Fix all compass modes - Githubissues

mself commented 4 years ago

Remove code for QWT < 6.0 in PitchCompassDrawWidget (it was too broken to fix)
Remove unnecessary calls to setSingleSteps() (the calls had no effect)
Move one-time config from PitchCompassDrawWidget::setCompassScale() to constructor
Don't use getCorrelation() >= 0.9 (use same logic as TunerView)
Update compass modes 0 and 1 to use closestNote() and temperedPitch()
Change scale for compass modes 0 and 1 to be 0-4
Move compass label logic from updateCompass() to setCompassScale()
Only blank compass needle -- not labels
Force update of compass for Mode1 correctly
Add padLabel() helper function to pad labels to equal width
Merge shared code for mode 0 and mode 1
Remove duplicate default value of PitchCompassView mode (don't define it twice)

With these changes, modes 0 and 1 also work:

Mode 0 is basically the same as the the Chromatic Tuner, but not as nice
Mode 1 is like Mode 0, but the dial moves instead of the needle
Mode 2 seems to be the easiest to use, since the labels stay in the same locations

The only way to change modes is to edit the source code.

quicky2000 commented 4 years ago

Could you solve conflict ?

mself commented 4 years ago

Rebased and conflict resolved

quicky2000 commented 4 years ago

There is an issue pitchcompassdrawwidget.cpp:213 l_active_channel is derefenced but it could be NULL

mself commented 4 years ago

No, if l_active_channel is NULL, then l_data remains NULL and the dereference of l_active_channel can't happen.

mself commented 4 years ago

I pushed a commit to simplify the logic so that it shouldn't trigger that warning.

quicky2000 / tartini