Closed mself closed 4 years ago
MusicScale
std::vector
Array1d
musicnotes.cpp
init()
g_music_scales
isChromaticScale
isMinorScale
isMajorScaleNote
isCompatibleWithTemparament
GData::m_music_key_type
int
MusicScale::ScaleType
GData::setTemperedType()
MainWindow::remove_key_type()
MainWindow::add_key_types()
MainWindow::updateKeyTypes()
temperedTypeChanged
thansk!
MusicScale
objects immutablestd::vector
instead ofArray1d
musicnotes.cpp
to staticinit()
methodg_music_scales
from global variable to private static member with accessor methodisChromaticScale
,isMinorScale
,isMajorScaleNote
, andisCompatibleWithTemparament
to remove business logic from UI layerGData::m_music_key_type
fromint
toMusicScale::ScaleType
GData::setTemperedType()
that removes and inserts items from the key types combo boxMainWindow::remove_key_type()
andMainWindow::add_key_types()
withMainWindow::updateKeyTypes()
temperedTypeChanged
signal toMainWindow::updateKeyTypes()
to update the combo box items when the tempered type is changed