search

quiclog / pcap2qlog

A tool to convert .pcap and .pcapng files into qlog files
MIT License
26 stars 7 forks source link

Qlog version 8 #14

Open auliasadil opened 3 months ago

auliasadil commented 3 months ago

So we want to improve the qlog version for pcap2qlog. Please accept our pull request 🙏. Oh yeah, these changes are related to the changes in this repo here

rmarx commented 3 months ago

Hey there @auliasadil,

Thanks for your interest in the qlog project and both PRs. It is however a bit difficult to just merge them at this time, since other projects (mainly qvis https://github.com/quiclog/qvis) depend on them, and those would first need changes to deal with the changes in the schema as well.

Next to that, your PRs only tackle a very small set of the changes to the qlog schema that are needed to bring the code up to date with the full latest version (e.g., many fields have changed names, events were removed/added/renamed/etc.), so doing a partial change to the newer schema only for some things makes little sense at this time.

I'm planning to do this full migration myself sometime in the coming months now that the qlog schema has settled done (somewhat at least) and to make the necessary changes in qvis.

Could you maybe let me know -why- exactly you're doing these changes now? Do you have other tools with dependencies on this for example? Is this blocking anything?