quiclog / pcap2qlog

A tool to convert .pcap and .pcapng files into qlog files
MIT License
26 stars 7 forks source link

Converter doesn't handle STREAM frames with implicit length #7

Open Matthias247 opened 3 years ago

Matthias247 commented 3 years ago

I noticed that when a STREAM frame is received which has no explicit length information (length is until end of packet) then no length field is logged in the stream event. Wireshark shows a length however, so the info might already be extracted somewhere?

Wireshark view: image

Emitted event:

[
    "15",
    "transport",
    "packet_received",
    {
        "packet_type": "1RTT",
        "header": {
            "dcid": "6ef15ae8d7504312",
            "packet_number": "957",
            "packet_size": 1200,
            "payload_length": 1189
        },
        "frames": [
            {
                "frame_type": "ack",
                "ack_delay": "0",
                "acked_ranges": [
                    [
                        "16",
                        "21"
                    ]
                ]
            },
            {
                "frame_type": "stream",
                "stream_id": "0",
                "offset": "1097128",
                "fin": false
            }
        ]
    }
],
rmarx commented 3 years ago

Hello Matthias,

Thanks for identifying the issue and submitting a PR!

Could you by any chance share a pcap containing this behaviour so I can test it before putting it live on qvis? Thanks!