search

quicwg / base-drafts

Internet-Drafts that make up the base QUIC specification
https://quicwg.org
1.63k stars 204 forks source link

Change packet number encoding example #4840

Closed martinthomson closed 3 years ago

martinthomson commented 3 years ago

For a reason I didn't bother to investigate this was wrong.

@MikeBishop, please double check. Anyone else who wants to double check, the extra effort would be appreciated.

larseggert commented 3 years ago

Is there an issue associated with this?

MikeBishop commented 3 years ago

This appears to check out, but obviously my math is suspect, having written the original example. :-)

bradfordwetmore commented 3 years ago

I am the person who pointed this out to @MikeBishop last night. These new numbers look correct to me.

Note, I am not involved with the draft writing, so can't approve this change.

Thanks for addressing.

martinthomson commented 3 years ago

Whether or not you can approve, I value the extra validation. At this stage, we can't afford to make this sort of mistake. And Mike, it's on me as much as you for not checking your numbers originally :)