search

quicwg / qlog

The IETF I-D documents for the qlog format
Other
77 stars 12 forks source link

Tweak trigger_frame_type field and add it to connection_closed #384

Closed LPardue closed 4 months ago

LPardue commented 5 months ago

Tweaks the language related to the ConnectionCloseFrame trigger_frame_type and adds it to connection_closed event.

Closes #366

rmarx commented 5 months ago

While I like the general prose editorial work, I'm personally not too convinced that we need the trigger_frame_type on the connectivity event. As stated elsewhere, you rarely get all combined information from a single qlog event, and you often need to look at surrounding events for more low-level info (in this case: a field specifically on the CONNECTION_CLOSE frame).

While I'm not terribly opposed to it, I'd still like to not add to the connectivity event, but do keep the editorial work with the CONNECTION_CLOSE frame (and maybe just reference that for the connectivity event?)

LPardue commented 5 months ago

While I'm not terribly opposed to it, I'd still like to not add to the connectivity event, but do keep the editorial work with the CONNECTION_CLOSE frame (and maybe just reference that for the connectivity event?)

Makes sense, I spun it off to its own PR https://github.com/quicwg/qlog/pull/386.

If we want to do a cross reference from connection_closed, then lets do that separate

rmarx commented 4 months ago

As explained above, I think we should close this without action (i.e., don't add trigger_frame_type to connection_closed)