search

quicwg / qlog

The IETF I-D documents for the qlog format
Other
83 stars 12 forks source link

How is "trigger" a common subfield of "data"? #429

Open LPardue opened 2 months ago

LPardue commented 2 months ago

In https://quicwg.org/qlog/draft-ietf-quic-qlog-main-schema.html#section-8.2-5 we say:

Any generic key-value map type can be assigned to $ProtocolEventData (the only common "data" subfield defined in this document is the optional trigger field, see Section 7.4).

I don't quite understand how this is a common field, since there is no CDDL for it. Should we be defining $ProtocolEventData with the actual optional ?trigger field? Or is is more like "common by convention" or some other magic.

Or is it actually the case that "trigger" is a design pattern that concrete event definitions can adopt but that they must explicitly declare the trigger field in their event definition?

LPardue commented 2 months ago

FWIW: Of this 40 events we define for QUIC and H3, only 10 of them currently define a trigger field.