search

quicwg / qlog

The IETF I-D documents for the qlog format
Other
86 stars 13 forks source link

Add unknown_parameters field #438

Closed rmarx closed 1 month ago

rmarx commented 1 month ago

Closes #436

I decided not add something similar to h3:parameters_set since it makes more sense to just log it as H3Settings there, and that's already possible.

rmarx commented 1 month ago

PTAL @hawkinsw @LPardue , I think this covers the load :)

hawkinsw commented 1 month ago

Sorry I was slow getting mine ready. I just added another PR that adds unknown parameters in a few additional places. If you would prefer to keep it to just the parameters_set, then that's great. I fixed another small typo in my PR. So, if you do end up accepting this PR rather than mine, I will open another one with just that typo fix. Sorry again for not getting this done sooner. I'm really disappointed in myself.