search

quiet / libcorrect

C library for Convolutional codes and Reed-Solomon
BSD 3-Clause "New" or "Revised" License
373 stars 95 forks source link

Replace CMAKE_*_DIR with PROJECT_*_DIR #10

Closed pietern closed 6 years ago

pietern commented 7 years ago

This makes it possible to embed libcorrect in a larger project where the source is not located at the CMake root but rather the project root.

brian-armstrong commented 6 years ago

Sorry, I should have got to this sooner.

This first change looks good, but what's the point of removing ASAN? I don't have any interest in removing that since it has already found many bugs.

pietern commented 6 years ago

Hey, the asan commit is unrelated to the CMake one. I just reused the same branch to fix a build. Passing -fsanitize=address implies needing to link to the asan library, which is not done here. I wasn't able to get asan to work on FreeBSD, which meant that I can't do debug builds with this enabled. Happy to submit another PR for it if you are OK with turning asan into a separate option.

In the mean time I'm cleaning up this branch so it is mergeable.

pietern commented 6 years ago

@brian-armstrong I think this is ready to go. The Travis failure looks unrelated.

brian-armstrong commented 6 years ago

Looks good! I am going to have that test retry. The test is a little flaky unfortunately -- the downsides to PRNG-based FEC tests :)

pietern commented 6 years ago

Thanks!