quiet / libcorrect

C library for Convolutional codes and Reed-Solomon
BSD 3-Clause "New" or "Revised" License
379 stars 94 forks source link

Added Debian Package on CPACK #4

Open racerxdl opened 7 years ago

racerxdl commented 7 years ago

I added the CPACK stuff for generating debian packages just by using make package inside build folder. Libcorrect is a dependency of my libSatHelper on https://github.com/opensatelliteproject so it would be usefull to have a package generator on the github repository :D

racerxdl commented 7 years ago

I also added some fixes for Visual Studio. It was actually working here, but Visual Studio doesn't save everything when Hit Ctrl +S or closing the app. Now its fixed.

racerxdl commented 7 years ago

Actually wait to merge, the paths are not in Release mode.

brian-armstrong commented 7 years ago

@racerxdl

Sorry I haven't had much time to review this. Looks like you're making good progress.

One thing I'd be curious to see is if we could generate VS stuff with cmake -G instead, since that would probably track VS updates better in the future.

Aside from that, I think I'd be hesitant to apply DLL_EXPORT like this everywhere, but I know that I also need to add extern C everywhere. I'll see if I can think of a way that does both in the right situations.