quiet / libfec

Clone of Phil Karn's libfec with capability to build on x86-64
117 stars 57 forks source link

CMake build #4

Closed v1bri closed 7 years ago

v1bri commented 8 years ago

Not really an issue, but would you guys be interested in adding CMake support to the project? I find it helps with cross compiling. I can submit a pull request if that works.

brian-armstrong commented 8 years ago

Well, CMake would definitely make it nicer. It's already arguably broken on osx.

One thing I'd want to see in a CMake impl would be a check for the x86 intrinsics, since libfec can build much faster SSE binaries if those instructions are available.

v1bri commented 8 years ago

I think I've got most of that covered. All feedback welcome.

brian-armstrong commented 7 years ago

Merged. Thanks again :)

sanjeev1994 commented 7 years ago

error: fec_get_enc_msg_length(), convolutional codes unavailable (install libfec)

i installed libfec and then also i am getting the above error

brian-armstrong commented 7 years ago

@sanjeev1994 I think your error belongs in its own issue, and likely on the quiet project

The next step you'll want to do is re-build/install liquid-dsp. Since you likely built it before having libfec installed, it wouldn't have built is libfec component. Now that you have it, it'll detect it when you rebuild it, and put the libfec handler in to its build. Then you error should go away

sanjeev1994 commented 7 years ago

Hi Brian Armstrong, I did the the same thing , I installed remaining dependencies and then only I built the liquid-dsp. And even now I tired I am getting the same.

Regards Sanjeev S On Sat, 13 May 2017 at 1:11 AM, Brian Armstrong notifications@github.com wrote:

@sanjeev1994 https://github.com/sanjeev1994 I think your error belongs in its own issue, and likely on the quiet project

The next step you'll want to do is re-build/install liquid-dsp. Since you likely built it before having libfec installed, it wouldn't have built is libfec component. Now that you have it, it'll detect it when you rebuild it, and put the libfec handler in to its build. Then you error should go away

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quiet/libfec/issues/4#issuecomment-301168152, or mute the thread https://github.com/notifications/unsubscribe-auth/AHE7G3tOb5zDYKl2f4pFaENYHP8kxmydks5r5LXMgaJpZM4JfcKk .

jgaeddert commented 7 years ago

@sanjeev1994, after installing libfec, you might need to run sudo ldconfig to bind the libraries so they can be linked externally.

sanjeev1994 commented 7 years ago

@jgaeddert I am using mac os. sudo ldconfig is not needed and mac os and that command cant be run in mac os also. If i run that command i am getting this error "sudo: ldconfig: command not found"

brian-armstrong commented 7 years ago

@sanjeev1994 Please move this discussion to a new issue. Also, when you do, post any output from liquid's ./configure regarding fec. You should see a couple of lines there regarding either finding or not finding fec.