search

quiet / quiet-js

Transmit data with sound using Web Audio -- Javascript binding for libquiet
BSD 3-Clause "New" or "Revised" License
2.2k stars 151 forks source link

edited cable-highspeed to cable-64k in button properties #31

Open ckhordiasma opened 5 years ago

ckhordiasma commented 5 years ago

When I was trying out the live demo, I noticed the image transfer was not working (this is also documented as an issue by someone else). When I looked into it, I found the error simply to be that the profile name used for the image receiver "cable-highspeed" did not match the one for the image transmitter "cable-64k"

Looking at the profiles JSON file, it seems like "cable-highspeed" does not exist, but "cable-64k" does. Once I made the change, the image transfer worked on my local working copy of the live example.

ckhordiasma commented 5 years ago

I guess this also highlights that maybe something should throw an error if a profile does not exist in the given JSON file.. Once I understand the source code a bit better I might try putting in a pull request for that.