search

quiet / quiet-js

Transmit data with sound using Web Audio -- Javascript binding for libquiet
BSD 3-Clause "New" or "Revised" License
2.2k stars 151 forks source link

Do you want this published on npm? #8

Open iameli opened 8 years ago

iameli commented 8 years ago

I forked and added a package.json here so that I could install with npm and experiment with using it to sync audio feeds in Stream Kitchen.

If you like I could throw in a couple scripts to automatically pull down the latest version of quiet and push it to npm.

(Thanks a ton for the project, by the way. FWIW I'd like to eventually write node bindings to the C code, but for now I'm just using the emscripten module server-side and it works fine.)

brian-armstrong commented 8 years ago

I had been holding off on publishing because quiet.js doesn't adhere to the javascript exports pattern (notably, quiet.js creates global variables and doesn't handle dependencies nicely). I will be the first to admit that I don't know the node etiquette very well but it seemed like everyone does that, and I figured the change would end up breaking existing usages a little. I got blocked because it turned out to be somewhat nonobvious to get working with the emscripten blobs, especially libfec, which also creates some global state.

If you have any opinions on that, I'd definitely like to hear them. I will decide within a few days how I feel about this issue.

Also, glad to hear it might be useful to you. Quiet is in a weird sort of limbo state where I think it's mostly working and useful but there aren't any production uses of it, aside from the demos I've made. I'll definitely be curious to hear your feedback after you have integrated it.

dcntrlz commented 7 years ago

there are 2 npm mod publish

https://www.npmjs.com/package/quiet.js https://www.npmjs.com/package/quiet-js

brian-armstrong commented 7 years ago

I need to just do this already. The modules are mine - they're just placeholders. This task is blocked on me getting quiet.js's API into a cleaner state that doesn't pollute global namespace. It's almost there, I just need to get motivated on it to finish

eliliam commented 7 years ago

@iameli I am trying to use this library on a node server, how exactly did you impliment it and do you have any code I can work with? I really like the idea of porting a version of this to NPM.