quietvoid / dovi_tool

dovi_tool is a CLI tool combining multiple utilities for working with Dolby Vision.
MIT License
582 stars 57 forks source link

Add level 255 support #107

Closed saindriches closed 2 years ago

saindriches commented 2 years ago

We don't know much about it, and only guarantee that the generated data is accepted by verifier.

quietvoid commented 2 years ago

Not sure why the verifier would accept it. Documentation says:

These metadata levels, if present, should be located in dm_data_payload(): 0, 1, 2, 4, 5, 6, and 255.

So the 255 should be along DM v1 blocks (or CM v2.9 in the code).

And when trying to verify with your code:

Invalid DM metadata level location [E238]. Found level 255 extension in payload 2

saindriches commented 2 years ago

You're right, I was focused on if the verifier parses blocks correctly (using -rt) and was unaware of this part. It should be a dmv1 block, will fix it.

quietvoid commented 2 years ago

Looks fine and works on my side. I'll add the C API part later.

Thanks!