quietvoid / dovi_tool

dovi_tool is a CLI tool combining multiple utilities for working with Dolby Vision.
MIT License
641 stars 59 forks source link

HDR10+ to DoVi Conversion Issue #52

Closed synacktic closed 3 years ago

synacktic commented 3 years ago

The issue may be that it can't be done and I just misunderstood, but:

  1. I used the most recent binary of the hdr10 tool to export the hdr10+
  2. I used the most recent dovi_tool binary to convert the json into an RPU
  3. I injected the RPU back into the original file
  4. Looked at the media info for the file and I see HDR10+ listed, not DV

Commands run: ffmpeg -i hdr10plus_movie.mkv -map 0:v:0 -c copy -vbsf hevc_mp4toannexb -f hevc - | hdr10plus_tool extract -o hdr10plus_metadata.json -

ffmpeg -i hdr10plus_movie.mkv -c:v copy -vbsf hevc_mp4toannexb -f hevc hdr10plus_movie.hvec

dovi_tool generate -j assets/generator_example.json --hdr10plus-json hdr10plus_metadata.json -o RPU_from_hdr10plus.bin

dovi_tool inject-rpu -i hdr10plus_movie.hvec --rpu-in RPU_from_hdr10plus.bin -o injected_output.hevc

So, am I doing something wrong or just wrong about the expected result?

Thanks for your time and a million thanks for your tools!

quietvoid commented 3 years ago

You need to mux the video in a compatible container for MediaInfo to show the Dolby Vision information. MKVToolnix, MP4Box and tsMuxer support this.

synacktic commented 3 years ago

I tried that previously, but now that you mention it, I was probably not using the latest MKVToolnix. I'll update and try again

synacktic commented 3 years ago

Yup, my boneheaded mistake using an old MKVToolnix, all is well now.

Thanks for the tools, very good stuff.