quietvoid / dovi_tool

dovi_tool is a CLI tool combining multiple utilities for working with Dolby Vision.
MIT License
623 stars 59 forks source link

Dv5 to 8 #62

Closed Harybo closed 2 years ago

Harybo commented 2 years ago

Hello,

when I convert from profile 5 to 8 it works fine but when I look at the result afterwards it gives me brightness peaks 1 second after each scene change

quietvoid commented 2 years ago

You probably have to edit the metadata to account for the timing difference between the two sources. See documentation: https://github.com/quietvoid/dovi_tool/blob/main/editor.md

Harybo commented 2 years ago

I think this is the solution but I have this problem all the time, with any video every time there are brightness peaks. Could it be a problem on your side because to tell you the 2 sources have the same number of frames and when I compare one frame between the two sources they are identical

Harybo commented 2 years ago

I think I have found the solution but I am not sure. I think if you do the conversion from 5 to 8 it automatically adds 40 frames to the rpu file which screws up the dv. I left the 40 frame remove as in your example and now all my results don't have the brightness problem.

quietvoid commented 2 years ago

No, the metadata order and count is not changed by the conversion. You should check and see if the brightness changes are in the source video.

Harybo commented 2 years ago

on the dv 5 source i don't have a brightness problem, it's really when i convert the dv 5 to 8 and implement it to an hdr source

quietvoid commented 2 years ago

So there's a difference in frames, edit the RPU accordingly.

Harybo commented 2 years ago

It's weird because this problem happens with any source. And it's always the same. And yet the frames are identical. So I think that's where the problem is, I can't see anything else. It's always the peak brightness comes after about 1 second after the scene change so it's consistent

quietvoid commented 2 years ago

There's nothing I can do without knowing the title.

Harybo commented 2 years ago

what do you mean by title?

quietvoid commented 2 years ago

The title of the film or whatever it is you're trying to convert.

Harybo commented 2 years ago

dune

Harybo commented 2 years ago

the series see, foundation, film reminiscence. Here are all the tests that have the same problem

quietvoid commented 2 years ago

I'm unable to reproduce the issue. The RPU from the profile 5 file matches the order after conversion as well as after injection into the HDR10 stream.

Harybo commented 2 years ago

I have the impression that it's the same order but I don't know what's going on but they are out of sync. Do you think staxrip could be the problem?

quietvoid commented 2 years ago

I don't know.

Harybo commented 2 years ago

I want to do a last test to see if the problem comes from you or from staxrip but how do you integrate the hdr parameters when I want to inject the dolby vision in the hdr source

quietvoid commented 2 years ago

I don't understand what you mean.

Harybo commented 2 years ago

forget it, I'm testing something to see if the problem comes from dovi_tool or staxrip

Harybo commented 2 years ago

So I found the problem. It was coming from my mkv extractor which added extra frames and also removed the hdr. I don't know why. But the problem is fixed.

Thanks for your help