search

quietvoid / dovi_tool

dovi_tool is a CLI tool combining multiple utilities for working with Dolby Vision.
MIT License
582 stars 57 forks source link

The 'main' thread panics when converting profile 5 to 8 with the latest version 1.3.1 #80

Closed manuelrn closed 2 years ago

manuelrn commented 2 years ago

Hi!

With the latest version (1.3.1), I get this error when using mode 3 (converts profile 5 to 8): thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', dolby_vision\src\rpu\rpu_data_mapping.rs:236:46

This does not happen with the previous version.

Thanks and regards!

quietvoid commented 2 years ago

Can you mention the source of the RPU? It is erroring on linear_interp_flag, which was previously assumed to never be used.

Or at least the RPU file itself would be useful.

manuelrn commented 2 years ago

I have tried several RPUs from different sources (Apple, Disney, Netflix, etc.), and I get that error with all of them. And many of them come from very recent content (for example 'The Power of the Dog' from Netflix).

quietvoid commented 2 years ago

Thanks. Looking into it.

quietvoid commented 2 years ago

I've fixed it in 57d2cfd130128a8963081c086d7b1a86e8b7ff5a.

You can test binaries once they're ready: https://github.com/quietvoid/dovi_tool/actions/runs/1557214604 Will create a release tomorrow (for me!)

quietvoid commented 2 years ago

Fixed in 1.3.2.

manuelrn commented 2 years ago

Thanks @quietvoid!

I have tried the new version and now it works correctly again.