search

quietvoid / dovi_tool

dovi_tool is a CLI tool combining multiple utilities for working with Dolby Vision.
MIT License
582 stars 57 forks source link

Thread hangs at "generating metadata" with Apple Silicon M1 chip using DoVi 4.0 XML #81

Closed jaynedoeh closed 2 years ago

jaynedoeh commented 2 years ago

Hello,

when using 1.3.0 stable, converting a DoVi 4.0 XML to a RPU bin file using --generate , the thread hans at "generate metadata" forever even when using a XML file with only one single shot. Using a 13" M1 MacBook Pro with Montery 12.0.1.

A DoVi 2.9 XML works fine though.

quietvoid commented 2 years ago

It seems to be broken because of the L3 metadata, and apparently I don't have an official sample for that. So I'll just fix it for generate, and if there are consequences we'll fix parsing with a proper sample later.

jaynedoeh commented 2 years ago

Here is a sample DoVi 4.0 XML:

https://pastebin.com/KxBYuBgW

quietvoid commented 2 years ago

Yeah I do have one, but level 3 metadata is not really used in RPUs because it's CMv4 metadata. And RPUs usually stick to only CMv2.9, which is why I don't have "real" samples.

jaynedoeh commented 2 years ago

Good to know, thanks for the heads up. :)

quietvoid commented 2 years ago

Should be fixed in 8f5bf223f540b653b4a0190d0352e422f3eba434. Will be in 1.3.2.

quietvoid commented 2 years ago

It seems level 3 metadata is supposed to be in another structure of the RPU, which is currently not supported. So the current behaviour may be incorrect.

quietvoid commented 2 years ago

DM v2 is fully supported in dovi_tool 1.4.5.

quietvoid commented 2 years ago

Same thing. Look it up.