[feature request] Implement AV1 support

cromefire commented 2 years ago

First and foremost: Yes it is still a draft and you may of course reject this idea, but due to it already having player support (Kodi on FireTV Max), seeming relatively straight forward (is seems to be based on the already existing ITU-T T.35 Metadata/SMPTE ST 2094-40) and seeming relatively stable for a few months, I feel like this would be a great addition as it allows conversion of existing h265 content to AV1 (or back if needed, although currently it doesn't seem like there's a lot of content).

Specification (draft): https://aomediacodec.github.io/av1-hdr10plus/ Sample file I have verified working (HDR10+ metadata arriving at the TV) with Kodi (Nexus) on my FireTV Max: https://github.com/AOMediaCodec/av1-hdr10plus/blob/ecdafef3eaf104135a6b28aabd960552e8209c7d/HDR10_SIZZLE_PLUS_UP-FINAL_02_AV1.mp4 AV1 bitstream parser library: https://github.com/yohhoy/av1parser

The bitstream parser above seems to already support ITU-T T.35 metadata and your code already supports the parsing of the metadata from bytes from (hopefully) the same format. So in theory it should be as easy as "only" creating some conditions to support more than one codec and some verification that it works. One additional problem might arise from the seeming lack of a .av1 format or something similar, all the AV1 people seem to be using .ivf files (that also seem to be really low overhead over a raw bitstream), but luckily there seems to be a rust implementation from rav1e. I have considered trying to integrate it myself, but as I lack knowledge of the format of the metadata the chances of success would be pretty low.

quietvoid commented 2 years ago

See https://github.com/yohhoy/av1parser/pull/14

I don't have any plan to support AV1 until the spec is finalized. Ideally we also need an encoder with support as reference.

quietvoid commented 1 year ago

https://github.com/xiph/rav1e/pull/3000 should be working fine to generate test streams. I'm not sure when I'll get around to this.

cromefire commented 1 year ago

Happy to test stuff, with Kodi, the FireTV and Panasonic OLED, I can actually test whether HDR10+ metadata is arriving at the TV (and it already works with AV1 & HDR10+).

quietvoid commented 1 year ago

Good to know. I can also test on a Samsung TV.

sven-pke commented 1 year ago

Any news about this?

quietvoid commented 1 year ago

Nope.

thePublicer commented 1 year ago

there is support to add hdr10+ to av1 see https://github.com/HandBrake/HandBrake/blob/master/NEWS.markdown

thePublicer commented 1 year ago

also any plans to extract hdr10plus from vp9?

JaitinPrakash commented 1 year ago

the official spec has reached a state where i believe you can now implement it. https://aomediacodec.github.io/av1-hdr10plus/

quietvoid commented 1 year ago

The complexity isn't in the HDR10+ spec but rather parsing AV1 bitstreams. There aren't stateful parsers that are usable so I'd probably have to implement one from scratch.

sven-pke commented 1 year ago

https://gstreamer.freedesktop.org/documentation/gst-plugins-bad-codecparsers/gstav1parser.html?gi-language=c I think Gstreamer is also available in Rust. Could that be an option?

quietvoid commented 1 year ago

GStreamer implies an additionnal dependency at runtime and I'd rather avoid that since it's more complicated for end users. I also can't seem to find Rust bindings to the codec parsers plugin, anyways.