Allow for lattice names in --isa (e.g. "Aspen-4-4Q-A").

quil-lang / quilc

The optimizing Quil compiler.

Apache License 2.0

460 stars 72 forks source link

Allow for lattice names in --isa (e.g. "Aspen-4-4Q-A"). #310

Open notmgsk opened 5 years ago

notmgsk commented 5 years ago

"8q-qvm" etc

ecpeterson commented 5 years ago

Seems reasonable to me!

erichulburd commented 4 years ago

@notmgsk ~Is this still relevant? Not seeing references to isa outside tests where they are just parsed with yason.~

~Are you looking to make use of the lattice names or just prevent them from breaking a parser?~

Just allow them in lookup-isa-descriptor-for-name app entrypoint? Just some basic matching for the \d+Q? I'd assume the lattice name or -qvm suffix isn't relevant there?

notmgsk commented 4 years ago

@erichulburd Yeah that's my thought. Mimic the behaviour (where appropriate) of pyQuil's get_qc.

notmgsk commented 4 years ago

One issue is that the forest server endpoints require HTTPS, and so if we were to pull data from forest server (e.g. for "Aspen-*" lattices) then we would introduce an SSL dependency. That's not a terrible thing, but it would likely mean that we have to distribute an SSL library with the SDK. We should decide whether the cost of that extra dependency is worth the utility of this feature.