search

quil-lang / quilc

The optimizing Quil compiler.
Apache License 2.0
460 stars 72 forks source link

Github CI failing in test-cl-quil due to Quicklisp's version of magicl being too old #772

Closed ghost closed 2 years ago

ghost commented 2 years ago

The Github CI for this repo invokes tests such that dependencies, including magicl and qvm, are loaded via quicklisp. Recently, cl-quil's .asd file was changed such that it depends on magicl version 0.10.0. However, the version that gets loaded is determined by Quicklisp, which currently gets version 0.7.0. Since qvm and magicl are very closely related and highly depended-upon systems, we should run the CI tests with a later, if not the latest, version of those systems, not the latest one that happens to be released by Quicklisp.

ghost commented 2 years ago

Here's a recent CI failure for a recent PR: https://github.com/quil-lang/quilc/runs/4112125272?check_suite_focus=true Attaching a screen shot of the failure.

CI Failure Screen Shot 2021-11-18 at 8 04 54 PM
ghost commented 2 years ago

PR https://github.com/quil-lang/quilc/pull/773, which has been merged, resolved this issue. Therefore, I'm closing this issue.