search

quil-lang / quilc

The optimizing Quil compiler.
Apache License 2.0
452 stars 73 forks source link

rename FOO.BAR packages to FOO/BAR #831

Closed stylewarning closed 2 years ago

stylewarning commented 2 years ago

This is a heavy renaming of all of our foo.bar package names to foo/bar.

The reason is that in old CMUCL and in Allegro CL, the foo.bar notation is for hierarchical packages, a non-standard Lisp feature that gives you nested namespaces. Moreover, the discrepancy between systems using / and packages using . had no good explanation.

This also removes all rename-package and conditionals on package-local-nicknames. We just assume you have it now.

This cleans up some existing nicknames due to issues/conflicts in the packages.lisp file

I'm a little worried I didn't replace everything in various scripts, dockerfiles, etc.

See also (required): https://github.com/quil-lang/qvm/pull/294

stylewarning commented 2 years ago

tests won't pass (edit: here on github) because qvm won't be able to load

stylewarning commented 2 years ago

I'm not convinced this PR is a good idea anymore.

  1. It does a bunch of different changes all in one PR.
  2. It breaks ~/.../ format strings, which can't be fixed without hacks
  3. It's not clear hierarchical packages are actually causing problems per se.