quil-lang / quilc

The optimizing Quil compiler.
Apache License 2.0
452 stars 73 forks source link

refactor give-up-compilation to remove frivolous :because kwarg #865

Closed macrologist closed 1 year ago

macrologist commented 1 year ago

This change offers a resolution to the complaint of #333. The refactor assumes that the complaint had to do with the frivolity of the mapping keyword names to error signalling forms.

If, however, the complaint was more involved - e.g. that there is an additional function call for signalling errors - then the form could be changed into a macro. It doesn't seem that the function bound to give-up-compilation is ever being used as a function value, so replacing it with a macro call should cause no difficulty.