quil-lang / quilc

The optimizing Quil compiler.
Apache License 2.0
452 stars 73 forks source link

standardize canonical coordinate conventions in quilc #869

Open macrologist opened 1 year ago

macrologist commented 1 year ago

The coordinates used in PCS, which I think are what's used here, have a goofy normalization condition that causes its canonical gates to span a triangular prism rather than a tetrahedron. ... inject an extra step here to re-scissor its output into the tetrahedron you expect ... I don't think much (anything?) in quilc depends on that alternative convention, and it was definitely a flub on our part not to do that from the start.

_Originally posted by @ecpeterson in https://github.com/quil-lang/quilc/pull/868#discussion_r1070677496_