search

quil-lang / quilc

The optimizing Quil compiler.
Apache License 2.0
452 stars 73 forks source link

Consistency fixes #873

Closed macrologist closed 1 year ago

macrologist commented 1 year ago

A few small changes, corrections,and bugfixes.

Some notes:

I'm unsure about the decision I made in commit 15d1558 to prefer lschedule and logical-schedule over names that end in scheduler. It could go either way - I chose this language because "addding to a schedule" makes more intutive sense (to me) than "adding to a scheduler". The commit is meant to address #692

153e0c9 is meant to address #662. I think I may agree with the now ghostly commenter who suggests that it probably isn't much of an issue. However, disallowing NIL as the source of a formal's name while still alowing the name "nil" pulled out of a :NIL seems like a fine compromise between the two positions. Being wary of NILs with unintended meanings seems like a fine suuperstition to adhere to in Common Lisp.

stylewarning commented 1 year ago

typo in your commit message: "replacement"