Move calculation of expectation values from QVM-APP to QVM

quil-lang / qvm

The high-performance and featureful Quil simulator.

Other

411 stars 57 forks source link

Move calculation of expectation values from QVM-APP to QVM #192

Open jmbr opened 4 years ago

jmbr commented 4 years ago

The functionality for computing expectation values that is currently available via the perform-expectation generic function in QVM-APP's src/api/expectation.lisp falls more naturally within the purview of the QVM.

In general, features that directly use an instance of a quantum virtual machine and can act as building blocks for higher-level APIs, belong to the QVM package.

jlapeyre commented 4 years ago

This seems reasonable prima facie.