search

quil-lang / qvm

The high-performance and featureful Quil simulator.
Other
411 stars 57 forks source link

EXTRACT-KRAUS-OPS: CL-QUIL::MAKE-ROW-MAJOR-MATRIX -> MAGICL:FROM-LIST #243

Closed appleby closed 4 years ago

appleby commented 4 years ago

The function CL-QUIL::MAKE-ROW-MAJOR-MATRIX was removed in https://github.com/rigetti/quilc/pull/574.

Switch to using MAGIC:FROM-LIST, instead.

notmgsk commented 4 years ago

Just as a note magicl supports setting the magicl::*default-tensor-type* which we could set in quilc to be (complex double-float) to avoid having to specify the type everywhere. This isn't needed for this PR but could be added in the future to clean up matrix construction calls

Do it 👍