search

quil-lang / qvm

The high-performance and featureful Quil simulator.
Other
411 stars 57 forks source link

temporary LOOP macro fix for AllegroCL #284

Closed franzinc closed 2 years ago

franzinc commented 2 years ago

Change-Id: I796bfffbaff2af3d607c94ae71b1c7de364992fd Reviewed-on: https://gerrit.franz.com:9080/c/qvm/+/19672 Reviewed-by: Tianyu Gu gty@franz.com Reviewed-by: Kevin Layer layer@franz.com Tested-by: Kevin Layer layer@franz.com

ghost commented 2 years ago

This is a temporary fix for Allegro's LOOP macro.

This fixes the unit test test-measure-semantics in https://github.com/quil-lang/quilc

stylewarning commented 2 years ago

This is a temporary fix for Allegro's LOOP macro.

This fixes the unit test test-measure-semantics in https://github.com/quil-lang/quilc

Is this just an Allegro bug that will get fixed in a release or so?

ghost commented 2 years ago

This is a temporary fix for Allegro's LOOP macro. This fixes the unit test test-measure-semantics in quil-lang/quilc

Is this just an Allegro bug that will get fixed in a release or so?

Yes, it will get fixed in a future release.

This is a somewhat begrudging approval. I'd prefer to not have vendor bug fixes for ANSI lisp in code ...

I agree. And thanks for merging it.