search

quilt / simulation

A tool to simulate Ethereum 2.0 execution
12 stars 2 forks source link

Add getters and setters for ShardChains, ExecutionEnvironments, and ShardBlocks #14

Closed gjtrowbridge closed 4 years ago

gjtrowbridge commented 5 years ago

Also allows for the retrieval of general ethereum simulation state, and implements basic From or TryFrom methods for converting between external-facing interface arguments and their (if any) corresponding internal representations.

gjtrowbridge commented 5 years ago

I considered splitting this into smaller diffs but decided this was easier to read as a whole and still not too large of a change. Please let me know if you feel differently as you review this: I'd like to (and believe as a team we should get into the habit of) making reviews easy to read and small enough to digest easily.

gjtrowbridge commented 5 years ago

Responded to some comments, Sam, thanks as always for the very thorough review! Looking forward to discussing some of these more offline.

gjtrowbridge commented 4 years ago

These changes merged via another PR.