quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.32k stars 91 forks source link

Double the expiration time of URL signing #3978

Closed fiskus closed 3 months ago

fiskus commented 3 months ago

5 minutes is too small amount of time for downloading some IGV tracks assets.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.63%. Comparing base (adaccad) to head (fb0d653).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3978 +/- ## =========================================== + Coverage 36.56% 89.63% +53.06% =========================================== Files 724 88 -636 Lines 32248 10616 -21632 Branches 4769 0 -4769 =========================================== - Hits 11793 9516 -2277 + Misses 19284 1100 -18184 + Partials 1171 0 -1171 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/3978/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/3978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `90.95% <ø> (ø)` | | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/3978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `?` | | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/3978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `87.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fiskus commented 3 months ago

I think, we no longer need this after https://github.com/quiltdata/quilt/pull/3979