Closed fiskus closed 3 months ago
Attention: Patch coverage is 50.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 36.68%. Comparing base (
9ea699f
) to head (4d22715
).
Files | Patch % | Lines |
---|---|---|
catalog/app/components/Preview/loaders/Igv.ts | 0.00% | 3 Missing :warning: |
...pp/components/Preview/loaders/useSignObjectUrls.ts | 66.66% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
is IGV able to accept async thunks instead of strings as URLs?
Yes, it is. Sorry, I didn't add this to the PR description.
They use their own helper module for every URL (though in documentation they said only about tracks
URLs), and it nailed down to that function where it is a check if URL is a string or a function, and those functions or strings could be async
:
https://github.com/igvteam/igv-utils/blob/master/src/igvxhr.js#L91
I can pass thunks but if indexURL
or indexFile
is omitted, they try to guess it, and it produces invalid URL like function(){}.fai
. I filed a bug and fix https://github.com/igvteam/igv.js/pull/1821
Hope they accept it, so I can remove our hacky fix: https://github.com/quiltdata/quilt/pull/3979/files#diff-6add50e55b85715ee3b4fb41a53452478a83ba438d1f94230d83bb7e6ba6d0acR81
Hope they accept it
looks like they did. not sure when they're going to cut their next release tho