quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.32k stars 91 forks source link

Use promises for URLs in IGV to have fresh signing each time they used #3979

Closed fiskus closed 3 months ago

fiskus commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 36.68%. Comparing base (9ea699f) to head (4d22715).

Files Patch % Lines
catalog/app/components/Preview/loaders/Igv.ts 0.00% 3 Missing :warning:
...pp/components/Preview/loaders/useSignObjectUrls.ts 66.66% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3979 +/- ## ========================================== + Coverage 36.56% 36.68% +0.11% ========================================== Files 724 724 Lines 32248 32254 +6 Branches 4605 4773 +168 ========================================== + Hits 11793 11833 +40 + Misses 19792 19259 -533 - Partials 663 1162 +499 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/3979/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/3979/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `90.95% <ø> (ø)` | | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/3979/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `10.70% <50.00%> (+0.18%)` | :arrow_up: | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/3979/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `87.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fiskus commented 3 months ago

is IGV able to accept async thunks instead of strings as URLs?

Yes, it is. Sorry, I didn't add this to the PR description. They use their own helper module for every URL (though in documentation they said only about tracks URLs), and it nailed down to that function where it is a check if URL is a string or a function, and those functions or strings could be async: https://github.com/igvteam/igv-utils/blob/master/src/igvxhr.js#L91

fiskus commented 3 months ago

I can pass thunks but if indexURL or indexFile is omitted, they try to guess it, and it produces invalid URL like function(){}.fai. I filed a bug and fix https://github.com/igvteam/igv.js/pull/1821 Hope they accept it, so I can remove our hacky fix: https://github.com/quiltdata/quilt/pull/3979/files#diff-6add50e55b85715ee3b4fb41a53452478a83ba438d1f94230d83bb7e6ba6d0acR81

nl0 commented 3 months ago

Hope they accept it

looks like they did. not sure when they're going to cut their next release tho