quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.32k stars 91 forks source link

TSify `utils/Dialogs` and some related code #3983

Closed nl0 closed 3 months ago

nl0 commented 3 months ago

Extracted from #3982

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 36.56%. Comparing base (883ee43) to head (f4bc8d3).

Files Patch % Lines
catalog/app/utils/Dialogs.tsx 0.00% 25 Missing :warning:
...og/app/containers/Admin/RolesAndPolicies/Roles.tsx 0.00% 2 Missing :warning:
...iners/Bucket/PackageDialog/PackageCreationForm.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3983 +/- ## ======================================== Coverage 36.56% 36.56% ======================================== Files 724 724 Lines 32248 32248 Branches 4769 4605 -164 ======================================== Hits 11793 11793 - Misses 19790 19792 +2 + Partials 665 663 -2 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/3983/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/3983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `90.95% <ø> (ø)` | | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/3983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `10.52% <0.00%> (ø)` | | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/3983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `87.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.