quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.33k stars 91 forks source link

Don't fold GQL `Me` data, split code to `MobileSignIn`/`DesktopSignIn` #3988

Closed fiskus closed 4 months ago

fiskus commented 4 months ago
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 36.27%. Comparing base (8b8c39c) to head (3bb1775).

Files Patch % Lines
catalog/app/containers/NavBar/NavBar.tsx 0.00% 51 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## users-gql #3988 +/- ## ============================================= - Coverage 36.38% 36.27% -0.12% ============================================= Files 734 734 Lines 32522 32515 -7 Branches 4861 4679 -182 ============================================= - Hits 11834 11794 -40 - Misses 19539 20079 +540 + Partials 1149 642 -507 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/3988/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/3988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `90.95% <ø> (ø)` | | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/3988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `10.40% <0.00%> (-0.18%)` | :arrow_down: | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/3988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `87.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nl0 commented 4 months ago

@fiskus is this kinda ready?

fiskus commented 4 months ago

Thank you, yes. I waited for CI checks to complete, and then forgot to request review