search

quiltdata / quilt

Quilt is a data mesh for connecting people with actionable data
https://quiltdata.com
Apache License 2.0
1.32k stars 91 forks source link

Use `meta.validating` instead of manually control state #3994

Closed fiskus closed 2 months ago

fiskus commented 3 months ago

This fixes Warning: Cannot update a component ('PackageCreationForm') while rendering a different component ('ForwardRef(Field)'). To locate the bad setState() call inside 'ForwardRef(Field)', follow the stack trace as described in https://reactjs.org/link/setstate-in-render

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.69%. Comparing base (b58a355) to head (4136cfe).

Files Patch % Lines
...app/containers/Bucket/PackageDialog/FilesInput.tsx 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3994 +/- ## ======================================== Coverage 36.68% 36.69% ======================================== Files 724 724 Lines 32254 32247 -7 Branches 4608 4769 +161 ======================================== Hits 11833 11833 + Misses 19758 19252 -506 - Partials 663 1162 +499 ``` | [Flag](https://app.codecov.io/gh/quiltdata/quilt/pull/3994/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | Coverage Δ | | |---|---|---| | [api-python](https://app.codecov.io/gh/quiltdata/quilt/pull/3994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `90.95% <ø> (ø)` | | | [catalog](https://app.codecov.io/gh/quiltdata/quilt/pull/3994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `10.71% <0.00%> (+<0.01%)` | :arrow_up: | | [lambda](https://app.codecov.io/gh/quiltdata/quilt/pull/3994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata) | `87.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=quiltdata#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.